resize, enter, leave, close events #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, Brandon! We're in the middle of a workweek but I'll take a look at this asap. Tests are always welcome - they're normally the first thing I look at to get an idea of what's been done :) (Check out test/qwidget.js for event testing examples). |
|
What is the progress on building the tests and applying the pull? These are pretty critical events - especially the close event! |
|
@arturadib I second the above. When can it be merged? (It's now been 7mo since above comment). |
|
@waddlesplash if someone can write tests I'd happily merge it :) it's not hard, see e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on tests but I'm slow at them